Skip to content

chore(http2): collapse duplicate request stream setup#5140

Open
trivikr wants to merge 1 commit intonodejs:mainfrom
trivikr:h2-avoid-duplicate-request-stream-branch
Open

chore(http2): collapse duplicate request stream setup#5140
trivikr wants to merge 1 commit intonodejs:mainfrom
trivikr:h2-avoid-duplicate-request-stream-branch

Conversation

@trivikr
Copy link
Copy Markdown
Member

@trivikr trivikr commented Apr 30, 2026

This relates to...

Internal HTTP/2 client request stream setup cleanup.

Rationale

The expectContinue and normal request paths in client-h2 duplicated stream creation and setup.
Sharing that setup reduces branch/code overhead and keeps the hot path easier to tune later.

Changes

  • Set the 100-continue header only when expectContinue is enabled.
  • Use one shared requestStream creation and setup path for both continue and normal requests.
  • Preserve the existing continue-specific listener and body write behavior.

Features

N/A

Bug Fixes

N/A

Breaking Changes and Deprecations

N/A

Status

Assisted-by: openai:gpt-5.5

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.25%. Comparing base (0ca054a) to head (68cc047).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5140   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files         110      110           
  Lines       36249    36241    -8     
=======================================
- Hits        33803    33797    -6     
+ Misses       2446     2444    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Assisted-by: openai:gpt-5.5
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
@trivikr trivikr force-pushed the h2-avoid-duplicate-request-stream-branch branch from 29ed787 to 68cc047 Compare May 1, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants