test(http2): ensure websocket upgrade resumes queued requests#5132
Open
trivikr wants to merge 1 commit intonodejs:mainfrom
Open
test(http2): ensure websocket upgrade resumes queued requests#5132trivikr wants to merge 1 commit intonodejs:mainfrom
trivikr wants to merge 1 commit intonodejs:mainfrom
Conversation
Assisted-by: openai:gpt-5.5 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5132 +/- ##
==========================================
- Coverage 93.14% 93.13% -0.01%
==========================================
Files 110 110
Lines 36117 36117
==========================================
- Hits 33642 33639 -3
- Misses 2475 2478 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Refs: #5131
Rationale
This was fixed in #5090, but I'd used an older state of main for generating bug report
Changes
Adds regression coverage for HTTP/2 WebSocket upgrades resuming queued requests.
Features
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status
Assisted-by: openai:gpt-5.5