fix(webidl): wrap negative values in ConvertToInt via two's complement#5107
Open
deepview-autofix wants to merge 1 commit intonodejs:mainfrom
Open
fix(webidl): wrap negative values in ConvertToInt via two's complement#5107deepview-autofix wants to merge 1 commit intonodejs:mainfrom
deepview-autofix wants to merge 1 commit intonodejs:mainfrom
Conversation
ConvertToInt's step 10 used JS `%`, whose result has the sign of the dividend, so negative inputs were not wrapped to the modulo range. For unsigned types without [EnforceRange]/[Clamp] this returned a negative number (e.g. -3 in 8 bits returned -3 instead of 253), and for signed types values in the one-wrap band below the lower bound were returned unchanged and outside the valid range (e.g. -200 in 8 bits returned -200 instead of 56). Implement ECMA-262's "x modulo y" semantics so the result lies in [0, 2^bitLength), matching typed-array behavior, and normalize -0 to +0. Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: DeepView Autofix <276251120+deepview-autofix@users.noreply.github.com> Co-Authored-By: Nikita Skovoroda <chalkerx@gmail.com> Signed-off-by: Nikita Skovoroda <chalkerx@gmail.com>
ChALkeR
suggested changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConvertToInt's step 10 used JS
%, whose result has the sign of the dividend, so negative inputs were not wrapped to the modulo range. For unsigned types without [EnforceRange]/[Clamp] this returned a negative number (e.g. -3 in 8 bits returned -3 instead of 253), and for signed types values in the one-wrap band below the lower bound were returned unchanged and outside the valid range (e.g. -200 in 8 bits returned -200 instead of 56). Implement ECMA-262's "x modulo y" semantics so the result lies in [0, 2^bitLength), matching typed-array behavior, and normalize -0 to +0.