Skip to content

chore: Apply linting everywhere#47

Merged
bizob2828 merged 1 commit intonodejs:mainfrom
jsumners-nr:lint-everything
Mar 27, 2026
Merged

chore: Apply linting everywhere#47
bizob2828 merged 1 commit intonodejs:mainfrom
jsumners-nr:lint-everything

Conversation

@jsumners-nr
Copy link
Copy Markdown
Contributor

As titled.

@jsumners-nr jsumners-nr marked this pull request as ready for review March 27, 2026 13:31
Copy link
Copy Markdown
Contributor

@timfish timfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost all this PR does is remove semicolons to match a specific opinionated linting setup.

I'm not keen on any linting/formatting that involves removing semicolons. Without them developers need to be aware of the automatic semicolon rules. This knowledge is not required when semicolons are used.

@jsumners-nr
Copy link
Copy Markdown
Contributor Author

This PR applies the linting rules already applied across the rest of the project. There's pretty much only two situations where ASI knowledge is needed:

function foo () {}
;(function IIFE () { /* do something */ })()
// ^ need the explicit semicolon
let a = 'foo'
console.log('bar')
;[a] = ['bam']
// I had to rip this from a SO answer because I couldn't even think of a way to induce it.

ASI is a non-issue.

Copy link
Copy Markdown
Contributor

@timfish timfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my bad. I misread the diff!

@bizob2828 bizob2828 merged commit c063643 into nodejs:main Mar 27, 2026
6 checks passed
@jsumners-nr jsumners-nr deleted the lint-everything branch March 27, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants