chore: Apply linting everywhere#47
Merged
bizob2828 merged 1 commit intonodejs:mainfrom Mar 27, 2026
Merged
Conversation
1d2981a to
b0a35f4
Compare
timfish
requested changes
Mar 27, 2026
Contributor
There was a problem hiding this comment.
Almost all this PR does is remove semicolons to match a specific opinionated linting setup.
I'm not keen on any linting/formatting that involves removing semicolons. Without them developers need to be aware of the automatic semicolon rules. This knowledge is not required when semicolons are used.
Contributor
Author
|
This PR applies the linting rules already applied across the rest of the project. There's pretty much only two situations where ASI knowledge is needed: function foo () {}
;(function IIFE () { /* do something */ })()
// ^ need the explicit semicolonlet a = 'foo'
console.log('bar')
;[a] = ['bam']
// I had to rip this from a SO answer because I couldn't even think of a way to induce it.ASI is a non-issue. |
timfish
approved these changes
Mar 27, 2026
Contributor
timfish
left a comment
There was a problem hiding this comment.
Oh my bad. I misread the diff!
bizob2828
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As titled.