add more tests, and some fixes to go along with them#4
Merged
Conversation
* indices, make them actually work * make multiple instrumentations in one file actually work
sabrenner
approved these changes
Mar 26, 2025
sabrenner
left a comment
sabrenner
left a comment
There was a problem hiding this comment.
fixes lgtm, especially with regards to the tests!
timfish
added a commit
to timfish/orchestrion-js
that referenced
this pull request
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debugin a few places to make debugging easier when solving problems like the above