Skip to content

src: fix escaping of single quotes in task runner#64089

Open
aduh95 wants to merge 4 commits into
nodejs:mainfrom
aduh95:task-runner-single-quotes
Open

src: fix escaping of single quotes in task runner#64089
aduh95 wants to merge 4 commits into
nodejs:mainfrom
aduh95:task-runner-single-quotes

Conversation

@aduh95

@aduh95 aduh95 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

FWIW here's the error on current main:

  AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
  + actual - expected
  
    {
  +   code: 1,
  -   code: 0,
      signal: null,
  +   stderr: "/bin/sh: -c: line 0: unexpected EOF while looking for matching `''\n" +
  +     '/bin/sh: -c: line 1: syntax error: unexpected end of file\n',
  +   stdout: ''
  -   stderr: '',
  -   stdout: `["I think therefore I'm"]\n`
    }

Refs: https://hackerone.com/reports/3817602

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants