process: fix finalization cleanup ref removal#64087
Open
trivikr wants to merge 2 commits into
Open
Conversation
Finalization cleanup used the ref index as part of the splice delete count. When a collected ref was not the first entry, cleanup could remove additional live refs from the internal list. Remove exactly the collected ref when it is present, so later live refs remain registered and still run their callbacks on process exit. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
nodejs-github-bot
added
needs-ci
Renegade334
reviewed
Jun 23, 2026
trivikr
force-pushed
the
lib-internal-process-finalization
branch
from
8af632e to
eb35666
Compare
Store finalization refs in SafeSet collections instead of arrays. This makes identity-based insertion, deletion, and emptiness checks match how the collections are used. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
trivikr
force-pushed
the
lib-internal-process-finalization
branch
from
eb35666 to
a4efd08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64086
When a registered object is garbage-collected, the cleanup path removes its
WeakReffrom the internal refs arrays. That path passedindex + 1as thesecond argument to
splice(), butsplice()expects a delete count, not an endindex. If the collected ref was not at index
0, cleanup could also removelater refs that were still live.
This updates cleanup to remove exactly one matching ref, and only when the ref
is present. A regression fixture registers three refs, lets the middle one be
collected, and verifies that the first and third live refs still run their
callbacks on process exit.
This also updates
lib/internal/process/finalization.jsto store finalization refs inSafeSetcollections instead of arrays.The refs were already being used with Set-like semantics: checking whether the
collection is empty, deleting refs by identity, and iterating over the active
refs. Using
SafeSetmakes that behavior explicit and simplifies cleanup logic.Duplicate registrations preserve the existing behavior because the set stores
distinct
WeakRefrecords, not the target objects.Assisted-by: openai:gpt-5.5