Skip to content

test: mark test-debugger-run-after-quit-restart as flaky on macOS#64006

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mcollina:mark-debugger-run-after-quit-restart-flaky-macos
Jun 20, 2026
Merged

test: mark test-debugger-run-after-quit-restart as flaky on macOS#64006
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mcollina:mark-debugger-run-after-quit-restart-flaky-macos

Conversation

@mcollina

@mcollina mcollina commented Jun 19, 2026

Copy link
Copy Markdown
Member

This test has been observed to be flaky on macOS CI due to slow inspector round-trips, causing a 15s timeout when waiting for the initial break after restart.

Refs: #64005

@mcollina mcollina requested a review from aduh95 June 19, 2026 15:52
@mcollina mcollina added the fast-track PRs that do not need to wait for 72 hours to land. label Jun 19, 2026
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @mcollina. Please 👍 to approve.

@lpinca

lpinca commented Jun 19, 2026

Copy link
Copy Markdown
Member

@inoway46 has been working on flaky debbugger tests and might have some ideas.

@inoway46

Copy link
Copy Markdown
Contributor

Thanks for the mention. I left a hypothesis-based comment on the issue: #64005 (comment)

Since the root cause is not fully clear yet, marking this as flaky for now sounds good to me.

Refs: nodejs#64005
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina force-pushed the mark-debugger-run-after-quit-restart-flaky-macos branch from 1734747 to 644625b Compare June 20, 2026 10:00
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 20, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2026
@nodejs-github-bot nodejs-github-bot merged commit c105c73 into nodejs:main Jun 20, 2026
72 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in c105c73

aduh95 pushed a commit that referenced this pull request Jun 20, 2026
Refs: #64005
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #64006
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 72 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants