crypto: support OpenSSL STORE private keys#63949
Open
panva wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Allow createPrivateKey() to load private keys from WHATWG URL objects through configured OpenSSL STORE providers. Reject built-in STORE loaders so this does not become a generic file or network URL loader, and gate the operation with the crypto.store permission. Mark resulting private KeyObjects as store-backed. Public rewrapping and private-key export are rejected, while provider-backed private operations use the existing EVP paths. Add hermetic STORE/keymgmt addon coverage and wire the pkcs11-provider SoftHSM test into shared-library CI for OpenSSL 3 and newer. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Work in progress
Allow createPrivateKey() to load private keys from WHATWG URL objects through configured OpenSSL STORE providers. Reject built-in STORE loaders so this does not become a generic file or network URL loader, and gate the operation with the crypto.store permission.
Mark resulting private KeyObjects as store-backed. Public rewrapping and private-key export are rejected, while provider-backed private operations use the existing EVP paths.
Add hermetic STORE/keymgmt addon coverage and wire the pkcs11-provider SoftHSM test into shared-library CI for OpenSSL 3 and newer (< 4.0 actually due to current SoftHSM incompatibility with 4.0).
Examples
Load a provider-backed private key and sign with it:
Use the Permission Model to bootstrap one signing key and then close the STORE-loading capability:
$ node --permission --allow-crypto-store app.mjsUse a provider-backed private key with WebCrypto as a non-extractable
CryptoKey: