doc: remove broken npm supported versions link#63672
Conversation
Signed-off-by: Hojeong Park <parkhj062@gmail.com>
|
Review requested:
|
There was a problem hiding this comment.
The old file used to exist in npm v7
https://github.com/npm/cli/blame/release/v7/lib/utils/unsupported.js
The replacement file
https://github.com/npm/cli/blob/latest/lib/cli/validate-engines.js
also refers back to
https://github.com/npm/cli/blob/latest/package.json#L252-L254
"engines": {
"node": "^20.17.0 || >=22.9.0"
}where the engines definition for node has no upwards restrictions.
So I'm not sure that keeping a link to https://github.com/npm/cli/blob/latest/lib/cli/validate-engines.js is necessary or relevant.
The old non-working link should however be removed in any case.
Signed-off-by: Hojeong Park <parkhj062@gmail.com> Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
|
@MikeMcC399 |
MikeMcC399
left a comment
There was a problem hiding this comment.
Since the section Release proposal (being changed in this PR) concerns informing the @nodejs/npm team about an upcoming major release, they should ideally participate in this PR review.
In any case, the rest of the Major releases section will need an overhaul since it does not yet take account of Evolving the Node.js Release Schedule, proposed for Node.js 27.
Commit Queue failed- Loading data for nodejs/node/pull/63672 ✔ Done loading data for nodejs/node/pull/63672 ----------------------------------- PR info ------------------------------------ Title doc: remove broken npm supported versions link (#63672) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch parkhojeong:fix-npm-supported-versions-link -> nodejs:main Labels doc Commits 2 - doc: update npm supported versions link - doc: remove npm supported versions link Committers 2 - Hojeong Park <parkhj062@gmail.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/63672 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/63672 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 31 May 2026 04:45:44 GMT ✔ Approvals: 3 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/63672#pullrequestreview-4408201133 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/63672#pullrequestreview-4438925869 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/63672#pullrequestreview-4444666393 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 63672 From https://github.com/nodejs/node * branch refs/pull/63672/merge -> FETCH_HEAD ✔ Fetched commits as 2adaeeee9cb7..2d2e87828df0 -------------------------------------------------------------------------------- [main 69953b7ac0] doc: update npm supported versions link Author: Hojeong Park <parkhj062@gmail.com> Date: Sun May 31 13:11:53 2026 +0900 1 file changed, 1 insertion(+), 1 deletion(-) [main 3db40e1246] doc: remove npm supported versions link Author: hojeong park <parkhj062@gmail.com> Date: Tue Jun 2 13:10:43 2026 +0900 1 file changed, 1 insertion(+), 2 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. (node:369) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- doc: update npm supported versions linkhttps://github.com/nodejs/node/actions/runs/27086912762 |
|
Landed in 45f6b83 |
Removes a broken npm supported versions link and its related sentence from the release guide.