hotfix: github actions scheduling#198
Merged
ovflowd merged 3 commits intonodejs:mainfrom Oct 27, 2025
Merged
Conversation
avivkeller
commented
Oct 27, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a GitHub Actions scheduling issue by removing the required: true constraint from workflow inputs. The change allows scheduled workflows to run without requiring explicit input values, while manual workflow dispatches can still optionally provide them.
Key Changes:
- Removed
required: truefromdry_runinput parameters in both manual and scheduled workflow files - Updated input reference from
github.event.inputs.dry_runtoinputs.dry_runfor proper context handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/create-meeting-artifacts-scheduled.yml |
Removed required constraint from dry_run input and corrected input reference syntax |
.github/workflows/create-meeting-artifacts-manual.yml |
Removed required constraint from dry_run input to allow optional usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Removed dry_run input from workflow dispatch.
ovflowd
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @ovflowd this should fix the scheduling issue, by making the input not required.