feat(calendar): use ical#194
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates from Google Calendar API to iCal-based calendar integration, enabling support for non-Google calendar providers and eliminating the need for Google API authentication tokens.
- Replaces Google Calendar API calls with iCal parsing for meeting date extraction
- Updates all meeting configuration templates to use
ICAL_URLinstead ofCALENDAR_ID - Removes Google API dependencies and authentication requirements
Reviewed Changes
Copilot reviewed 35 out of 38 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/google.mjs | Completely removed - Google Calendar API client and meeting search logic |
| src/calendar.mjs | New file implementing iCal-based meeting date finding |
| src/config.mjs | Removed Google API configuration section |
| package.json | Replaced @googleapis/calendar dependency with ical library |
| create-node-meeting-artifacts.mjs | Updated to use new calendar module instead of Google API |
| test/config.test.mjs | Removed Google API configuration tests |
| templates/* | Updated all meeting templates to use ICAL_URL instead of CALENDAR_ID |
| README.md | Removed Google API setup documentation |
| TEMPLATES_DOCUMENTATION.md | Updated template property documentation |
| .github/workflows/* | Removed GOOGLE_API_KEY environment variable |
| .env.example | Removed Google API key configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
cc @ovflowd |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 34 out of 37 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 34 out of 37 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 34 out of 37 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
(Drafting, as I need to work out an issue with UTC + iCal time zones |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 34 out of 37 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ovflowd
left a comment
ovflowd
left a comment
There was a problem hiding this comment.
Wait, nevermind, I found something I thought got addressed but it didn't. (We're almost there tho!!)
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 33 out of 36 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Bump @ovflowd, this should land soon, since LFX is now only using ical |
Replaces the use of the Google Calendar API with iCal, which not only lets us use non-Google providers, it also removes the need for a Google API token