Draft
Conversation
monorimet
reviewed
Sep 24, 2024
Collaborator
|
@gpetters-amd FWIW the existing api file in apps/shark_studio/api/sd.py can be converted to apps/shark_studio/api/turbine-models-sd.py (that's sort of what you have going at the moment, I think) and refactored to match an abstracted API established in this PR. That way we don't lose the idea you had of an inference engine-agnostic interface to the Studio WebUI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first step toward the SHARK refactor, right now it's just a skeleton but once I'm sure this is what we're going for I can add in the model complilation code (that's mostly going to be ported from Turbine) and get SD2 working soon.