Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is an attempt to investigate improvements to performance by trimming large types.
Motivation and Context
Large types presumably negatively affect the binary size and performance of the application. There are some large types discovered by the usage of
top-type-sizesAttrdue to it's use ofAttrIdin unknown variants, can be improved byBox-ingJobsdue to having many members, can be improved by usingVecofdynvaluesHow Has This Been Tested?
It seems that these changes has virtually no effect on runtime performance and the gains in binary size are marginal, going from
19.6MB->19.7MBTypes of changes
Fixes
Features
Breaking changes
Checklist: