You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I like the idea in general but the implementation would need a number of changes.
There's both a docker__default_daemon_json and docker__daemon_json variable that get merged together so we'd want to use combine() for that. Then there's updating the tests too.
I'm also not a fan of keeping around 2 documented ways to configure the same thing or the name of the variables themselves. Perhaps it could now be docker__daemon_options. If it were named that originally we could have gotten by with having both 1 set of variables and backwards compatibility at the jinja template level (if the var is a string do the old thing else do the new thing) but that ship has sailed.
I think the only real option is to bite the bullet and make a backwards incompatible change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #93