For discussion: Add Nunjucks page listing support#264
Draft
colinrotherham wants to merge 2 commits intomove-test-templatesfrom
Draft
For discussion: Add Nunjucks page listing support#264colinrotherham wants to merge 2 commits intomove-test-templatesfrom
colinrotherham wants to merge 2 commits intomove-test-templatesfrom
Conversation
colinrotherham
temporarily deployed
to
nhsuk-protot-page-index-uxgeby
colinrotherham
force-pushed
the
move-test-templates
branch
from
2096a00 to
45cc955
Compare
colinrotherham
force-pushed
the
page-index
branch
from
7baa861 to
08a8932
Compare
colinrotherham
temporarily deployed
to
nhsuk-protot-page-index-uxgeby
colinrotherham
force-pushed
the
move-test-templates
branch
from
45cc955 to
8359bb9
Compare
colinrotherham
force-pushed
the
page-index
branch
from
08a8932 to
7da3c6a
Compare
colinrotherham
temporarily deployed
to
nhsuk-protot-page-index-uxgeby
colinrotherham
force-pushed
the
page-index
branch
from
7da3c6a to
77a2c2f
Compare
colinrotherham
temporarily deployed
to
nhsuk-protot-page-index-uxgeby
colinrotherham
force-pushed
the
move-test-templates
branch
from
8359bb9 to
2cd24c7
Compare
colinrotherham
force-pushed
the
page-index
branch
from
77a2c2f to
da80870
Compare
colinrotherham
temporarily deployed
to
nhsuk-protot-page-index-uxgeby
Contributor
|
@colinrotherham nice! The downside with this approach I guess is that it doesn't work if you have custom routes? |
Contributor
Author
|
Yeah no custom routes, but still useful you said? 😎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes something like
{{ pageIndex() }}to list all pages within a directoryWould potentially close #169
For discussion if we find it useful