Increase unit coverage#1685
Open
craigell wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
chore
aphralG
reviewed
May 19, 2026
| return &crossplane.Config{Parsed: []*crossplane.Directive{events, http}} | ||
| } | ||
|
|
||
| func TestCrossplaneConfigTraverse_VisitsEveryDirective(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
Could the test's be grouped and use structs for differenet inputs and expected outputs like here in this file
| want []string | ||
| }{ | ||
| { | ||
| name: "empty map returns empty slice", |
Collaborator
There was a problem hiding this comment.
Could you add a number to the name of the tests is possible
| port int | ||
| expect bool | ||
| }{ | ||
| {"both set", "localhost", 1234, true}, |
Collaborator
There was a problem hiding this comment.
Could these be edited to be made more clear the value being set like the above test
Suggested change
| {"both set", "localhost", 1234, true}, | |
| { | |
| name: "both set", | |
| host: "localhost", | |
| port: 1234, | |
| expectL true | |
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Increased unit test coverage for agent v2.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)