fix(start): remove is_ready check#20
Open
kingmigdor wants to merge 3 commits intonextcord:masterfrom
Open
Conversation
This is blocking on_ipc_ready from the example, and might confuse people when the bot is not ready and the event is not being fired.
Collaborator
|
It seems like this reverts #2, is the runtime error handled any differently now? (Also, to fix the failing workflow, a rebase or merge should work.) |
Author
The change works for me and has been tested. I'm not sure what happened before, it would be helpful to see which error got raised. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is blocking on_ipc_ready from the example, and might confuse people when the bot is not ready and the event is not being fired. The PR simply removes the
bot.is_readycheck, since listeners are built up before the bot might be ready, as in the example the ipc server being started before bot.run.The only way for creating an ipc server is starting it before the bot loop is running.