fix(encryption): load wasm module on demand#18255
Merged
Merged
Conversation
- Encryption.isSupported() have a side effect of initializing Olm module - Should be pre-checked if needed by Encryption.isEnabled() - Already done in src/utils/webrtc/index.js, but not in src/utils/signaling.js - Migrated to async syntax Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
added
bug
feature: frontend 🖌️
fancycode
approved these changes
Jun 25, 2026
fancycode
left a comment
fancycode
left a comment
Member
There was a problem hiding this comment.
unless there is a reason to include features.push('encryption') from client side?
The SIP bridge checks that feature flag and only starts an e2ee session with a client if it is set, so it should not be removed.
Code looks good from a quick view, didn't test though.
ShGKme
approved these changes
Jun 25, 2026
Contributor
Author
|
/backport to stable34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
AI (if applicable)
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
features.push('encryption')from client side?🏁 Checklist