Skip to content

fix: add proper ACLs for trashbin proxys#60211

Open
hamza221 wants to merge 1 commit intomasterfrom
fix/trashbin-proxy-acls
Open

fix: add proper ACLs for trashbin proxys#60211
hamza221 wants to merge 1 commit intomasterfrom
fix/trashbin-proxy-acls

Conversation

@hamza221
Copy link
Copy Markdown
Contributor

@hamza221 hamza221 commented May 7, 2026

Summary

Add proper ACLs for proxys

How I tested

  1. Delegate User1 calendar to admin
curl -X PROPPATCH 'http://nextcloud.local/remote.php/dav/principals/users/user2/calendar-proxy-write' \
  -u 'user2:user2' \
  -H 'Content-Type: application/xml' \
  -b 'XDEBUG_SESSION=PHPSTORM' \
  --data-binary @- <<'EOF'
<?xml version="1.0" encoding="utf-8" ?>
<D:propertyupdate xmlns:D="DAV:">
	<D:set>
		<D:prop>
			<D:group-member-set>
				<D:href>/remote.php/dav/principals/users/admin</D:href>
			</D:group-member-set>
		</D:prop>
	</D:set>
</D:propertyupdate>
  1. enable delegation on the client
image
  1. Connect admin to an external client that supports delegation (Apple calendar)
image
  1. apply patch
image

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@hamza221 hamza221 force-pushed the fix/trashbin-proxy-acls branch from 16206b0 to 69b7f74 Compare May 7, 2026 11:19
@hamza221 hamza221 added this to the Nextcloud 34 milestone May 7, 2026
@hamza221 hamza221 self-assigned this May 7, 2026
@hamza221 hamza221 added bug 3. to review Waiting for reviews feature: caldav Related to CalDAV internals labels May 7, 2026
@hamza221 hamza221 requested review from GVodyanov and kesselb May 7, 2026 11:19
@ChristophWurst
Copy link
Copy Markdown
Member

/backport to stable33

@ChristophWurst
Copy link
Copy Markdown
Member

/backport to stable32

@hamza221
Copy link
Copy Markdown
Contributor Author

hamza221 commented May 7, 2026

/backport to stable33

@hamza221
Copy link
Copy Markdown
Contributor Author

hamza221 commented May 7, 2026

/backport to stable32

@hamza221
Copy link
Copy Markdown
Contributor Author

hamza221 commented May 7, 2026

@ChristophWurst didn't see your comments :'(

@hamza221 hamza221 enabled auto-merge May 7, 2026 11:26
@hamza221
Copy link
Copy Markdown
Contributor Author

hamza221 commented May 7, 2026

reuse unrelated #60205

The following files have no copyright and licensing information:
* apps/appstore/l10n/bg.js
* apps/appstore/l10n/bg.json
* apps/appstore/l10n/cs.js
* apps/appstore/l10n/cs.json
* apps/appstore/l10n/cy_GB.js
* apps/appstore/l10n/cy_GB.json
* apps/appstore/l10n/es_419.js
* apps/appstore/l10n/es_419.json
* apps/appstore/l10n/es_CO.js
* apps/appstore/l10n/es_CO.json
* apps/appstore/l10n/es_CR.js
* apps/appstore/l10n/es_CR.json
* apps/appstore/l10n/es_DO.js
* apps/appstore/l10n/es_DO.json
* apps/appstore/l10n/es_EC.js
* apps/appstore/l10n/es_EC.json
* apps/appstore/l10n/es_GT.js
* apps/appstore/l10n/es_GT.json
* apps/appstore/l10n/es_HN.js
* apps/appstore/l10n/es_HN.json
* apps/appstore/l10n/es_NI.js
* apps/appstore/l10n/es_NI.json
* apps/appstore/l10n/es_PA.js
* apps/appstore/l10n/es_PA.json
* apps/appstore/l10n/es_PE.js
* apps/appstore/l10n/es_PE.json
* apps/appstore/l10n/es_PY.js
* apps/appstore/l10n/es_PY.json
* apps/appstore/l10n/es_SV.js
* apps/appstore/l10n/es_SV.json
* apps/appstore/l10n/es_UY.js
* apps/appstore/l10n/es_UY.json
* apps/appstore/l10n/et_EE.js
* apps/appstore/l10n/et_EE.json
* apps/appstore/l10n/fi.js
* apps/appstore/l10n/fi.json
* apps/appstore/l10n/hu.js
* apps/appstore/l10n/hu.json
* apps/appstore/l10n/ja.js
* apps/appstore/l10n/ja.json
* apps/appstore/l10n/ka_GE.js
* apps/appstore/l10n/ka_GE.json
* apps/appstore/l10n/lt_LT.js
* apps/appstore/l10n/lt_LT.json
* apps/appstore/l10n/nb.js
* apps/appstore/l10n/nb.json
* apps/appstore/l10n/pt_PT.js
* apps/appstore/l10n/pt_PT.json
* apps/appstore/l10n/sc.js
* apps/appstore/l10n/sc.json
* apps/appstore/l10n/sk.js
* apps/appstore/l10n/sk.json

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 7, 2026
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 force-pushed the fix/trashbin-proxy-acls branch from 69b7f74 to 8350e96 Compare May 8, 2026 08:20
@hamza221
Copy link
Copy Markdown
Contributor Author

hamza221 commented May 8, 2026

rebased for green CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish backport-request bug feature: caldav Related to CalDAV internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Delegated calendars - Node with name 'trashbin' could not be found

3 participants