fix(macOS): present tray popup before app activation - #10582
Conversation
Order the native tray panel before activating the app so WindowServer can accept activation after an app-icon launch. Only mark the tray open when the panel is visible. Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
|
it works for me鈩笍 |
Rello
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26dddc85b5
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }; | ||
|
|
||
| private slots: | ||
| void ordersPopupBeforeRequestingApplicationActivation() |
There was a problem hiding this comment.
Add regression coverage for both visibility outcomes introduced by this change. This sole test replaces the three presentation operations with vector pushes and only verifies their order; it never exercises the new showMacOSTrayPopup() result or verifies that Systray::showTrayPopup() sets isOpen and fetches activity only when the native panel is visible. A regression that restores the stale-open state after a failed macOS presentation would therefore pass this test.
AGENTS.md reference: AGENTS.md:L207-L209
Useful? React with 馃憤聽/ 馃憥.
|
/backport to stable-34.0 |
|
Artifact containing the AppImage: nextcloud-appimage-pr-10582.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
2 participants
Order the native tray panel before activating the app so WindowServer can accept activation after an app-icon launch. Only mark the tray open when the panel is visible.
Assisted-by: Codex:GPT-5