Skip to content

feat: add board import and export#6872

Merged
luka-nextcloud merged 1 commit intomainfrom
board-import-export
Apr 30, 2025
Merged

feat: add board import and export#6872
luka-nextcloud merged 1 commit intomainfrom
board-import-export

Conversation

@luka-nextcloud
Copy link
Copy Markdown
Contributor

@luka-nextcloud luka-nextcloud commented Apr 1, 2025

  • Resolves: #
  • Target version: main

Summary

It makes it possible to export and import a deck board as a JSON/CSV file. CSV is only for export while JSON works for both import and export.

Video recording

demo.webm

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@luka-nextcloud luka-nextcloud self-assigned this Apr 1, 2025
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Apr 1, 2025
@luka-nextcloud luka-nextcloud moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Apr 1, 2025
@elzody
Copy link
Copy Markdown
Contributor

elzody commented Apr 4, 2025

It works quite well, the only thing I noticed was that when I upload a clearly incorrect .json file to see what it does, it throws an error (as expected) but with the actual log message that you would see in the nextcloud.log file:

"OCA\\Deck\\Service\\Importer\\BoardImportService::setData(): Argument #1 ($data) must be of type stdClass, string given, called in /var/www/master/apps-extra/deck/lib/Service/Importer/BoardImportService.php on line 123"

Maybe instead it should display something more readable, and also something that doesn't expose the internal path of some of the files (e.g. the /var/www/...)

By the way, I am talking about the error message that gets displayed in the top right to the user.

Signed-off-by: Luka Trovic <luka@nextcloud.com>
Copy link
Copy Markdown
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me now.

@luka-nextcloud luka-nextcloud merged commit 71b4700 into main Apr 30, 2025
38 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Apr 30, 2025
@luka-nextcloud luka-nextcloud deleted the board-import-export branch April 30, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants