Skip to content

Tenant monitoring policy - #260

Merged
juchowan merged 15 commits into
netascode:mainfrom
ogorczow:tenant-monitoring-policy
Jul 30, 2025
Merged

Tenant monitoring policy#260
juchowan merged 15 commits into
netascode:mainfrom
ogorczow:tenant-monitoring-policy

Conversation

@ogorczow

@ogorczow ogorczow commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

Added support for Tenant Monitoriong policies.

Location in GUI:
Tenant » XXX » Policies » Monitoring » XXX » Callhome/Smart Callhome/SNMP/Syslog

Test Data

apic:
  tenants:
    - name: 'tmon'
      policies:
        monitoring:
          policies:
            - name: test
              snmp_traps:
                - name: TRAP2
                - name: TRAP1
              syslogs:
                - name: syslog2  
                - name: syslog1
                  audit: false
                  events: false
                  faults: false
                  session: true
                  minimum_severity: alerts

@ogorczow
ogorczow marked this pull request as draft July 2, 2025 13:50
@ogorczow
ogorczow marked this pull request as ready for review July 9, 2025 08:42
@ogorczow

ogorczow commented Jul 9, 2025

Copy link
Copy Markdown
Contributor Author

tested code:

---
apic:
  tenants:
    - name: 'tmon'
      policies:
        monitoring:
          policies:
            - name: test
              snmp_traps:
                - name: TRAP2
                - name: TRAP1
              syslogs:
                - name: syslog2  
                - name: syslog1
                  audit: false
                  events: false
                  faults: false
                  session: true
                  minimum_severity: alerts
              fault_severity_policies:
                - class: vzRsSubjFiltAtt
                  faults:
                    - fault_id: F1127
                      initial_severity: warning
                      target_severity: inherit
                      description: test
                    - fault_id: F0756

ghost
ghost reviewed Jul 17, 2025
View reviewed changes
Comment thread aci_tenants.tf Outdated
Comment thread modules/terraform-aci-tenant-monitoring-policy/variables.tf Outdated
Comment thread modules/terraform-aci-tenant-monitoring-policy/variables.tf Outdated
juchowan
juchowan requested changes Jul 29, 2025
View reviewed changes
Comment thread aci_tenants.tf Outdated
}

locals {
tenant_montioring_policy = flatten([

@juchowan juchowan Jul 29, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still typo

@ogorczow ogorczow Jul 30, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment thread aci_tenants.tf Outdated

module "aci_tenant_monitoring_policy" {
source = "./modules/terraform-aci-tenant-monitoring-policy"
for_each = { for pol in local.tenant_montioring_policy : pol.key => pol if local.modules.aci_tenant_monitoring_policy && var.manage_tenants }

@juchowan juchowan Jul 29, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@ogorczow ogorczow Jul 30, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@ogorczow
ogorczow requested a review from juchowan July 30, 2025 08:28
@juchowan
juchowan merged commit 21b41b7 into netascode:main Jul 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juchowan juchowan Awaiting requested review from juchowan
2 more reviewers
@jmiguelhp jmiguelhp jmiguelhp left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ogorczow @juchowan @jmiguelhp