fix: resolve 4 pre-existing test failures - #142
Open
jexp wants to merge 1 commit into
Open
Conversation
- Export splitIntoLines from circleWordWrap.js (arrows-ts + arrows-app): the TS port only exported fitTextToCircle, leaving the test importing a non-existent function. Added the simple word-wrap helper the tests document. - Delete apps/arrows-ts/src/app/app.spec.tsx: Nx-generated boilerplate that renders <App> without a Redux Provider and asserts 'Welcome arrows-ts' text that never existed in the real app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two unrelated pre-existing failures, both introduced when the TS port was created in #130.
circleWordWrap.test.js—splitIntoLines is not a functionThe test imports
splitIntoLinesfromcircleWordWrap.js, but the TS port (and the originalarrows-app) only ever exportedfitTextToCircle. The function was never added.Fix: export
splitIntoLinesfrom botharrows-tsandarrows-app. The implementation is a simple word-wrap helper (measure each word individually; start a new line when a word exceedslineWidth; never leave a line empty) consistent with what the test documents.app.spec.tsx— Nx boilerplate, never applicableGenerated by Nx scaffold, it renders
<App>without a ReduxProviderand asserts"Welcome arrows-ts"text that has never existed in the real app. Deleted.Result