fix: use __REDUX_DEVTOOLS_EXTENSION_COMPOSE__ to avoid Redux error #0 - #140
Open
jexp wants to merge 1 commit into
Open
fix: use __REDUX_DEVTOOLS_EXTENSION_COMPOSE__ to avoid Redux error #0#140jexp wants to merge 1 commit into
jexp wants to merge 1 commit into
Conversation
The old pattern passed the DevTools enhancer as preloadedState and the middleware enhancer as the third arg, which breaks when the Redux DevTools browser extension is installed (causes "Minified Redux error #0" blank screen). The correct pattern uses __REDUX_DEVTOOLS_EXTENSION_COMPOSE__ (falling back to Redux's own compose) so both enhancers are composed safely as a single store enhancer. Fixes #133
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__REDUX_DEVTOOLS_EXTENSION__pattern increateStorewith the correct__REDUX_DEVTOOLS_EXTENSION_COMPOSE__approachcomposewhen the extension is not present, so behavior is unchanged for users without DevTools installedRoot cause
The old code passed two separate enhancers to
createStore:This is only safe in certain Redux 4.x code paths and breaks with the DevTools extension's newer API. The correct pattern composes them into one:
Fixes #133