fix: better local dev experience - #126
Open
danstarns wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve the local development experience for the Nx-managed Arrows monorepo, specifically addressing arrows-app install and Vite CommonJS/require interoperability issues described in #125.
Changes:
- Adds a root
postinstallstep to installapps/arrows-appdependencies automatically. - Introduces
vite-plugin-commonjsand wires it into thearrows-appVite config. - Expands
DEVELOP.mdwith clearer install/build/dev-server instructions.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| package.json | Adds postinstall to install apps/arrows-app deps; adds vite-plugin-commonjs. |
| package-lock.json | Lockfile updates reflecting the new dev dependency and dependency tree changes. |
| DEVELOP.md | Adds installation/build guidance and updates dev-server command wording. |
| apps/arrows-app/vite.config.js | Enables vite-plugin-commonjs alongside the React plugin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "license": "Apache2", | ||
| "scripts": { | ||
| "build": "nx run arrows-ts:build" | ||
| "postinstall": "cd ./apps/arrows-app && npm install --force", |
| "scripts": { | ||
| "build": "nx run arrows-ts:build" | ||
| "postinstall": "cd ./apps/arrows-app && npm install --force", | ||
| "build": "nx run arrows-ts:build" |
| css: true, | ||
| }, | ||
| plugins: [react()], | ||
| plugins: [react(), commonjs()], |
|
|
||
| ## Installation | ||
|
|
||
| To setup this workspace, run the following command at the root of the repo: |
| npm install | ||
| ``` | ||
|
|
||
| > The repo is due some dependency updates, if you have conflicts locally on install, please attach the `--force` flag to the command above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
Changes: