Skip to content

feat(network): rewire PMA consumers to use transport and connected_peers (8/n)#15576

Merged
shreyan-gupta merged 2 commits intomasterfrom
shreyan-gupta/network/deentangle/08
Apr 28, 2026
Merged

feat(network): rewire PMA consumers to use transport and connected_peers (8/n)#15576
shreyan-gupta merged 2 commits intomasterfrom
shreyan-gupta/network/deentangle/08

Conversation

@shreyan-gupta
Copy link
Copy Markdown
Contributor

@shreyan-gupta shreyan-gupta commented Apr 15, 2026

  • Block/headers/epoch-sync broadcast → transport.broadcast_message(T2, ...)
  • Per-peer sends (BlockRequest, etc.) → transport.send_message(T2, ...)
  • SyncSnapshotHosts broadcast → transport.broadcast_message(T2, ...)
  • Highest-height peer queries → state.peers.tier2() + to_highest_height_peer_info helper
  • Peer matching/filtering → state.peers.tier2() instead of state.tier2.load().ready

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.47%. Comparing base (6ff3b8b) to head (62b76bf).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ain/network/src/peer_manager/peer_manager_actor.rs 87.50% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #15576   +/-   ##
=======================================
  Coverage   69.46%   69.47%           
=======================================
  Files         942      942           
  Lines      214969   214991   +22     
  Branches   214969   214991   +22     
=======================================
+ Hits       149334   149357   +23     
- Misses      59716    59720    +4     
+ Partials     5919     5914    -5     
Flag Coverage Δ
pytests-nightly 1.14% <0.00%> (-0.01%) ⬇️
unittests 68.91% <87.50%> (+<0.01%) ⬆️
unittests-nightly 69.01% <87.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/08 branch from 5e71525 to 6284e77 Compare April 15, 2026 13:50
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/07 branch 2 times, most recently from 5ca1a60 to a622b9d Compare April 15, 2026 19:22
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/08 branch 2 times, most recently from 00169d9 to cb81b43 Compare April 15, 2026 22:35
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/07 branch from a622b9d to 86d7eb3 Compare April 15, 2026 22:35
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/08 branch from cb81b43 to c3d7b23 Compare April 15, 2026 22:39
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/07 branch 2 times, most recently from 24d7e74 to f58c995 Compare April 15, 2026 23:04
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/08 branch 2 times, most recently from 73be26e to 2ade8e3 Compare April 16, 2026 02:37
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/07 branch from f58c995 to be1d301 Compare April 16, 2026 02:37
@shreyan-gupta shreyan-gupta changed the title feat(network): [8/n] rewire PMA consumers to use transport and connected_peers feat(network): 8/n rewire PMA consumers to use transport and connected_peers Apr 16, 2026
@shreyan-gupta shreyan-gupta changed the title feat(network): 8/n rewire PMA consumers to use transport and connected_peers feat(network): rewire PMA consumers to use transport and connected_peers (8/n) Apr 16, 2026
@shreyan-gupta shreyan-gupta marked this pull request as ready for review April 16, 2026 04:13
@shreyan-gupta shreyan-gupta requested a review from a team as a code owner April 16, 2026 04:13
@shreyan-gupta shreyan-gupta requested review from VanBarbascu, pugachAG, wacban and walnut-the-cat and removed request for a team April 16, 2026 04:13
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/08 branch from 2ade8e3 to bae8f46 Compare April 23, 2026 15:03
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/07 branch 2 times, most recently from 7bd84df to fa8bbac Compare April 23, 2026 21:44
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/08 branch from bae8f46 to 4f340b9 Compare April 23, 2026 21:44
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/07 branch from fa8bbac to a0dcdca Compare April 23, 2026 22:05
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/08 branch 2 times, most recently from 98e8627 to c26743f Compare April 27, 2026 14:13
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/07 branch from a0dcdca to c2ed5f7 Compare April 27, 2026 14:13
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/08 branch from c26743f to 7590600 Compare April 27, 2026 19:13
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/07 branch 2 times, most recently from 23388bd to 942b085 Compare April 27, 2026 19:57
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/08 branch 2 times, most recently from 7f980ec to dc3dced Compare April 27, 2026 21:22
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/07 branch 2 times, most recently from 40ce58d to a5c7cb8 Compare April 27, 2026 22:04
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/08 branch 2 times, most recently from 167fa39 to c7e60b3 Compare April 27, 2026 22:16
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/07 branch 2 times, most recently from a83854c to b774ffb Compare April 27, 2026 22:33
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/08 branch 2 times, most recently from 3ef6472 to 623360b Compare April 27, 2026 22:53
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/07 branch 2 times, most recently from 4a69807 to 9869ba3 Compare April 27, 2026 23:29
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/08 branch 2 times, most recently from 0f151fe to 87b937e Compare April 28, 2026 14:55
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/08 branch from 87b937e to 19f37fb Compare April 28, 2026 19:47
@shreyan-gupta shreyan-gupta requested a review from frol as a code owner April 28, 2026 19:47
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/07 branch from 27c372d to 864d458 Compare April 28, 2026 20:03
Base automatically changed from shreyan-gupta/network/deentangle/07 to master April 28, 2026 21:11
shreyan-gupta and others added 2 commits April 28, 2026 17:15
…ted_peers

Rewire PMA handlers to use the transport trait and connected_peers
instead of direct Pool reads:

- Block broadcast: self.state.tier2.broadcast_message → self.transport.broadcast_message(T2)
- BlockRequest, EpochSyncRequest: self.state.tier2.send_message → self.transport.send_message(T2)
- SyncSnapshotHosts: self.state.tier2.broadcast_message → self.transport.broadcast_message(T2)
- highest_height_peers: reads connected_peers instead of tier2.load().ready
- unreliable_peers: reads connected_peers instead of tier2.load().ready
- PartialEncodedChunkRequest peer matching: reads connected_peers instead of tier2.load().ready

Remaining PMA Pool reads (is_outbound_bootstrap_needed,
maybe_stop_active_connection, monitor_peers_trigger,
get_network_info, report_bandwidth_stats_trigger) need Pool-level
info (outbound_handshakes count, per-connection bandwidth stats)
and will move with the Pools in PR 9.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@shreyan-gupta shreyan-gupta force-pushed the shreyan-gupta/network/deentangle/08 branch from 19f37fb to 62b76bf Compare April 28, 2026 21:15
@shreyan-gupta shreyan-gupta added this pull request to the merge queue Apr 28, 2026
Merged via the queue into master with commit 36db40b Apr 28, 2026
32 checks passed
@shreyan-gupta shreyan-gupta deleted the shreyan-gupta/network/deentangle/08 branch April 28, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants