test: add integration tests for foreign chain requests - #2820
Merged
Conversation
DSharifi
marked this pull request as ready for review
April 10, 2026 11:44
…tests-foreign-chain-requests
Contributor
Author
|
@claude review |
Contributor
Author
|
@claude review |
Code ReviewNo critical issues found. This is a clean, test-only PR that adds integration tests for foreign chain requests covering three important scenarios:
Good use of ✅ Approved Generated by Claude Code |
DSharifi
enabled auto-merge
April 10, 2026 12:25
anodar
previously approved these changes
Apr 10, 2026
anodar
previously approved these changes
Apr 10, 2026
gilcu3
requested changes
Apr 13, 2026
gilcu3
left a comment
gilcu3
left a comment
Contributor
There was a problem hiding this comment.
Thank you!
In the current PR we are adding duplicate code, and not following the current code organization. We should sort these out before merging.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 13, 2026
…tests-foreign-chain-requests
gilcu3
approved these changes
Apr 13, 2026
anodar
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2821