Skip to content

fix: witness should not inherit serde traits - #2748

Merged
SimonRastikian merged 16 commits into
mainfrom
simon/witness-deserialization
Apr 13, 2026
Merged

fix: witness should not inherit serde traits#2748
SimonRastikian merged 16 commits into
mainfrom
simon/witness-deserialization

Conversation

@SimonRastikian

Copy link
Copy Markdown
Contributor

Closes #2747

@SimonRastikian
SimonRastikian changed the base branch from main to simon/assert-no-panic April 8, 2026 09:53
@SimonRastikian SimonRastikian self-assigned this Apr 8, 2026
@claude

claude Bot commented Apr 8, 2026

Copy link
Copy Markdown

Code Review: fix: witness should not inherit serde traits

Clean, focused security improvement. Removing Serialize/Deserialize from Witness<C> prevents accidental serialization of private scalar material. The struct already correctly implements Zeroize + Drop, and no existing code depends on serde for this type.

✅ Approved — no critical issues found.

netrome
netrome previously approved these changes Apr 8, 2026
gilcu3
gilcu3 previously approved these changes Apr 8, 2026
Base automatically changed from simon/assert-no-panic to main April 13, 2026 13:26
@SimonRastikian
SimonRastikian dismissed stale reviews from gilcu3 and netrome April 13, 2026 13:26

The base branch was changed.

@SimonRastikian
SimonRastikian added this pull request to the merge queue Apr 13, 2026
Merged via the queue into main with commit 9869eab Apr 13, 2026
27 checks passed
@SimonRastikian
SimonRastikian deleted the simon/witness-deserialization branch April 13, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Witness should not inherit serde traits to prevent leakage

3 participants