Fix invalid ConfiguredName for sunrise and sunset - #328
Open
jmnovak50 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HAP-NodeJS validates the
ConfiguredNamecharacteristic and warns when it contains unsupported punctuation.The sunrise and sunset services currently set dynamic
ConfiguredNamevalues such as:Sunriseː 05:14:40Sunsetː 20:28:18This results in repeated HAP-NodeJS warnings because the names contain the modifier colon character and time punctuation.
This change assigns stable and valid
ConfiguredNamevalues:SunriseSunsetThe existing dynamic
Namevalues remain unchanged, so the current sunrise and sunset times continue to be displayed.