Add default/fallback container for unassigned sites#2879
Open
tigredcarta wants to merge 1 commit intomozilla:mainfrom
Open
Add default/fallback container for unassigned sites#2879tigredcarta wants to merge 1 commit intomozilla:mainfrom
tigredcarta wants to merge 1 commit intomozilla:mainfrom
Conversation
When no specific container is assigned to a site, automatically open it in a user-configured fallback container. Configurable from the options page under a new "Default container" section. - assignManager: add _maybeFallbackContainerCookieStoreId() to look up the setting and verify the container still exists (auto-cleans if deleted) - onBeforeRequest: redirect to fallback container when no site assignment matches and the fallback is configured - options.html/options.js: new UI dropdown to select the fallback container Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_maybeFallbackContainerCookieStoreId()method inassignManagerreads the setting from storage, verifies the container still exists (auto-cleans if deleted), and returns the targetcookieStoreId.onBeforeRequest()redirects to the fallback container when no site assignment matches and the fallback is configured — the tab is replaced cleanly using the existingcreateTabWrapper()path.Test plan
firefox-defaultas beforeNotes
The i18n strings (
defaultContainer,defaultContainerLabel,defaultContainerDescription,defaultContainerNone) need to be added to the l10n submodule separately.Closes #503 (partial — this implements the catch-all default; always-open-in-no-container is tracked separately in #2860)
🤖 Generated with Claude Code