Refactor FXIOS-15348 [Technical Debt] [Redux] Use @Copyable macro for RemoteTabsPanelState#34762
Open
hkarmoush wants to merge 2 commits into
Open
Refactor FXIOS-15348 [Technical Debt] [Redux] Use @Copyable macro for RemoteTabsPanelState#34762hkarmoush wants to merge 2 commits into
hkarmoush wants to merge 2 commits into
Conversation
The titleLabel in MicrosurveyPromptView was constrained to match the headerView's height, creating a circular dependency that collapsed the label to a single line regardless of numberOfLines=0. Additionally, the headerView's .fillProportionally distribution squeezed the label width inappropriately. Fixed by: 1. Removing the circular height constraint on titleLabel 2. Changing headerView distribution from .fillProportionally to .fill This allows the title to wrap naturally and the prompt card to grow to fit its content, especially important for longer survey titles and larger Dynamic Type sizes.
… RemoteTabsPanelState
hkarmoush
force-pushed
the
remotetabspanel-copyable-macro
branch
from
July 22, 2026 15:42
2b52999 to
6bc411e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Applies the
@Copyablemacro (from theModifiedCopypackage) toRemoteTabsPanelState, replacing the reducer's manual full-constructor reconstructions with.copy(...)chains that only touch the fields actually changing in each action handler. This follows the same pattern already established in the codebase (e.g.SearchBarState,HomepageState) and applied most recently toTabPeekStatein #34744.No behavioral change —
defaultState(from:)and the existing convenience initializers (init(appState:uuid:),init(windowUUID:)) are left untouched, consistent with how other@Copyablemigrations in this codebase handle those.🎥 Demos
N/A — internal Redux state refactor, no UI change.
📝 Checklist
RemoteTabsPanelTests.swiftcoverage is unaffected since the memberwise initializer used there is untouched by@Copyable