Add instrumented E2E tests and emulator CI job#1
Open
morozione wants to merge 3 commits into
Open
Conversation
- Library: Compose UI tests for RollingAnimatedText (initial render, digit rolling, odometer growth 99->100, animateChanges=false, non-digit replacement, auto-size in narrow container) - Sample: full-activity E2E tests launching MainActivity via createAndroidComposeRule, clicking the real counter buttons and asserting the rolled result (scoped by a new counter test tag) - CI: new e2e job enabling KVM and running connectedDebugAndroidTest for both modules on an API 34 emulator
48dp cannot fit 10 digit slots even at the 10sp minimum font size, so the row overflowed and the last digit failed assertIsDisplayed. Use 120dp: still forces auto-size to shrink from 32sp, but the shrunk row fits and every digit stays visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
library/src/androidTest): Compose UI tests forRollingAnimatedText— initial render, digit change settling on the new value, odometer growth (99 -> 100), instant update withanimateChanges = false, non-digit replacement, auto-size in a narrow container.sample/src/androidTest): launches the realMainActivitywithcreateAndroidComposeRule<MainActivity>(), clicks the actual counter buttons (+1 / +10 / -1) and asserts the rolled result. Assertions are scoped via a newcountertest tag since the balance section also renders digits.e2ejob that enables KVM, boots an API 34 emulator (reactivecircus/android-emulator-runner) and runsconnectedDebugAndroidTestfor both modules. Runs in parallel with the existingbuildjob.CLAUDE.md(build commands + architecture notes).Notes
waitUntilfor that.androidx.compose.ui.test.junit4.v2rules (the non-v2 ones are deprecated in this Compose version).