fix: add locale fallback for region-specific locales (e.g. en-US) - #7952
Open
awath-abdat wants to merge 1 commit into
Open
fix: add locale fallback for region-specific locales (e.g. en-US)#7952awath-abdat wants to merge 1 commit into
awath-abdat wants to merge 1 commit into
Conversation
When a browser reports a region-specific locale like en-US, the app tries to load lang/en-US.json which does not exist, causing the page to render without translations. The resolve function now tries the exact locale, swapped separator (en_US), base language (en), and falls back to English. Fixes monicahq#7910
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
en-USthat has no matchinglang/en-US.jsonfilelocale.jsmodule used by bothapp.jsandssr.jsen-US<->en_US) -> base language (en) -> English fallbackFixes #7910
Test plan
en-USand verify the "Add Contact" page renders correctly with all form labelspt-BRlocale still loads correctly (existingpt_BR.json)en,fr,de) continue to worknpx vite buildandnpx vite build --ssrto confirm both builds pass