-
Notifications
You must be signed in to change notification settings - Fork 8
sec: introduce zizmor actions scanner #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
5abc639
1f42c2f
5266f58
d4f4594
e8c43be
39c5050
c761e38
dddc214
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| name: Moneyhub - Github Actions Security with zizmor 🌈 | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| push: | ||
| branches: | ||
| - main | ||
|
MH-Fergus marked this conversation as resolved.
|
||
|
|
||
| permissions: {} | ||
|
|
||
| jobs: | ||
| zizmor: | ||
| name: Run zizmor 🌈 | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| security-events: write | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing contents and actions read permissions for zizmorMedium Severity The workflow sets |
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Install the latest version of uv | ||
| uses: astral-sh/setup-uv@5a095e7a2014a4212f075830d4f7277575a9d098 # v7.3.1 | ||
|
|
||
| - name: Run zizmor 🌈 | ||
| shell: bash | ||
| run: uvx zizmor . | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
MH-Fergus marked this conversation as resolved.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing SARIF upload step in zizmor workflowHigh Severity The workflow generates SARIF output to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Zizmor scan results never uploaded as SARIFMedium Severity The job requests Additional Locations (1) |
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing NODE_AUTH_TOKEN for private package installation
High Severity
The old
moneyhub/checkout-and-setup@v1receivednpm-token: ${{ secrets.NPM_TOKEN }}with an explicit comment that it was "still used for registry auth during install (e.g. private scopes)." The replacementactions/setup-nodewithregistry-urlcreates an.npmrcreferencingNODE_AUTH_TOKEN, but that environment variable is never set. The private@mft/eslint-config-momentumftdevDependency will fail to install even oncenpm ciis added back.