fix: change customer email property type to a nullable string#882
Open
edwinvdpol wants to merge 1 commit intomollie:mainfrom
Open
fix: change customer email property type to a nullable string#882edwinvdpol wants to merge 1 commit intomollie:mainfrom
edwinvdpol wants to merge 1 commit intomollie:mainfrom
Conversation
Collaborator
|
Thanks @edwinvdpol , let me verify this. |
sandervanhooft
approved these changes
Apr 24, 2026
Collaborator
|
Hi @edwinvdpol , Double check to ensure we get this right: this looks like an issue raised by a static type checker, i.e. PHPStan, correct? So the code itself is not actually throwing an exception? |
Contributor
Author
|
Hi @sandervanhooft, It did throw an exception in production after I added
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hi 👋
After I added strict type to my PHP file, I got this error in production:
in this line of code:
This PR changes the customer email property type to a nullable string.