Skip to content

update log filehandler#1292

Merged
Yunnglin merged 3 commits intomainfrom
fix_0414
Apr 15, 2026
Merged

update log filehandler#1292
Yunnglin merged 3 commits intomainfrom
fix_0414

Conversation

@Yunnglin
Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings April 14, 2026 13:08
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements memory optimizations by clearing dataset and evaluator references after use, updates NLTK tokenizer loading to support punkt_tab, and introduces a ReopenFileHandler to improve log visibility on FUSE-mounted filesystems. Review feedback identifies a hardcoded local path in the test suite that should be removed, points out redundant code in the evaluation loop, and suggests refactoring duplicated logic while cautioning against potential performance degradation from the new file handler on standard filesystems.

Comment thread tests/benchmark/test_eval.py
Comment thread evalscope/run.py Outdated
Comment thread evalscope/utils/logger.py Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR primarily aims to improve log visibility on OSS/FUSE-mounted filesystems by changing how file logging is handled, and it also includes a few runtime memory-reduction tweaks plus an NLTK tokenizer fallback update.

Changes:

  • Introduce ReopenFileHandler and use it for non-DEBUG file logging to force close/reopen per log record (better OSS/FUSE “near real-time” log visibility).
  • Reduce peak memory by releasing per-benchmark evaluator objects during evaluate_model() and clearing adapter dataset references in finalize().
  • Update iFEval sentence tokenizer loading to prefer punkt_tab (with fallback to classic punkt).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/benchmark/test_eval.py Updates GSM8K test invocation (now sets debug=False and adds a fixed use_cache path).
evalscope/utils/logger.py Adds ReopenFileHandler and switches file handler selection logic based on log_level.
evalscope/run.py Frees evaluator objects during evaluation loop to reduce memory accumulation.
evalscope/benchmarks/ifeval/instructions_util.py Adds check_nltk_data('punkt_tab') + tokenizer loading fallback logic.
evalscope/api/benchmark/adapters/default_data_adapter.py Clears dataset references in finalize() to release memory post-eval.

Comment thread tests/benchmark/test_eval.py
Comment thread evalscope/run.py Outdated
Comment thread evalscope/utils/logger.py Outdated
Comment thread evalscope/utils/logger.py Outdated
Yunnglin and others added 2 commits April 15, 2026 10:19
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@Yunnglin Yunnglin merged commit 19d9f1d into main Apr 15, 2026
3 checks passed
@Yunnglin Yunnglin deleted the fix_0414 branch April 15, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants