fix(memory): resolve Vitest false positive for expected rejection#3893
Open
JosephDoUrden wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(memory): resolve Vitest false positive for expected rejection#3893JosephDoUrden wants to merge 1 commit intomodelcontextprotocol:mainfrom
JosephDoUrden wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Wrap the addObservations call in an async closure before asserting with .rejects.toThrow(). This prevents Vitest's global unhandled rejection handler from capturing the expected error before the assertion can intercept it, eliminating the false-positive "Unhandled Errors" warning that was failing CI. Fixes modelcontextprotocol#3073
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addObservationscall in an async closure before asserting with.rejects.toThrow(), so Vitest's global unhandled rejection handler does not capture the expected error before the assertion intercepts itFixes #3073
Root cause
addObservationsis an async function that throws synchronously inside a.map()callback. When passed directly toexpect().rejects.toThrow(), the resulting Promise rejection is seen by Vitest's global rejection handler before the.rejectswrapper can intercept it. Wrapping inasync () => { await ... }ensures the rejection is properly scoped.Changes
src/memory/__tests__/knowledge-graph.test.ts: Wrap the assertion in an async closureTest plan
npx vitest run)AI Disclosure
AI assistance (Claude) was used for issue research. The implementation was written and reviewed by the author.