Fix custom-header schema freshness#358
Open
jstar0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the positive
http-custom-headersmock advertise a freshtools/listschema before requiring clients to mirrorx-mcp-headerparameters intoMcp-Param-*request headers.Root Cause / Context
http-custom-headersreturnedtools/listwithttlMs: 0, which marks the tool schema immediately stale. The scenario then required the followingtools/callto includeMcp-Param-*headers derived from that schema.A strict client that composes the custom-header and caching rules can reasonably treat that schema as stale and omit schema-derived headers. That makes the positive custom-header scenario fail because of the mock's cache hint rather than the client's header support.
Changes
tools/listresponse to use a positive TTL.Mcp-Param-*headers when the listed schema is fresh, then asserts all custom-header checks pass.Scope / Risk
This only changes the positive
http-custom-headersclient scenario. The invalid-tool scenario and other cacheable mock responses are unchanged.Verification
All commands passed.
Closes #354