You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I added TypeScript support so that those who use it can benefit. I did have to update the ical.js version so that we can link into their provided types. Thanks for your consideration!
Hi @mifi, thank you for the merge! Unfortunately, due to the ical.js downgrade, the types don't appear to be fully functional. TS definitions were not added until 2.1.0, so any references to ical.js objects will be any, and VS Code confirms this when drilling deeper:
I understand the concern about updating to a new major version, but it may be a necessary evil. There is only one breaking change in the 2.0.0 release: adoption of ES6 syntax. ES6 was released over 10 years ago now, so I imagine the impact of this will be minimal. So long as we too note this in the release notes, I would be surprised if anyone turns their nose at it
Sorry I missed this. Yes I tested with ical.js@2.2.1 and everything worked great. Later versions probably work just as well but I haven't confirmed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added TypeScript support so that those who use it can benefit. I did have to update the
ical.jsversion so that we can link into their provided types. Thanks for your consideration!