Improve styling #981
Open
UnnaturalTwilight wants to merge 4 commits intomierak:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes more styles stack on others to make theming more consistent.
text_colorhighlight_border_styledefaults toborders_stylecurrent_item_stylefor active tab andtext_colorfor inactive tabOnly the model change should affect fully defined themes but the rest of the changes make theming more forgiving to incomplete themes and reduce the effects of adding new theme options as they inherit from the existing options.
Related issues
This is progress on #920 but not a full implementation of text color
Checklist
If these changes are ok I will work on a pr for the docs.