fix: clarify cloneSlice comment to explain shallow vs deep copy semantics#1710
Open
alexchenai wants to merge 1 commit intomiekg:masterfrom
Open
fix: clarify cloneSlice comment to explain shallow vs deep copy semantics#1710alexchenai wants to merge 1 commit intomiekg:masterfrom
alexchenai wants to merge 1 commit intomiekg:masterfrom
Conversation
…tics The previous comment simply stated "shallow copy" which was confusing given that cloneSlice is used to implement deep-copy functions (e.g. Copy). The new comment explains that while the slice elements are not deep-copied (making it a shallow copy), for slices of value types like []byte this effectively produces a deep copy. Fixes miekg#1709 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloneSlicecomment said "shallow copy" which was confusing since it's used inCopy()which advertises deep-copy semantics[]byteas used bynet.IP), this effectively produces a deep copyTest plan
🤖 Generated with Claude Code