[http-client-csharp] Fix BinaryContent wrapping in MethodParameterSegments navigation#10740
Open
JonathanCrd wants to merge 1 commit into
Open
[http-client-csharp] Fix BinaryContent wrapping in MethodParameterSegments navigation#10740JonathanCrd wants to merge 1 commit into
JonathanCrd wants to merge 1 commit into
Conversation
…n MethodParameterSegments navigation When MethodParameterSegments navigation resolves to a BinaryData property, the expression was passed directly as a BinaryContent protocol argument without wrapping. This caused a CS1503 compilation error. Wrap the resolved property expression with RequestContentApiSnippets.Create() when the protocol parameter is a content parameter. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
microsoft-github-policy-service
Bot
added
the
emitter:client:csharp
commit: |
JonathanCrd
requested review from
JoshLove-msft,
ShivangiReja,
christothes,
jorgerangel-msft,
joseharriaga,
jsquire and
m-nash
as code owners
Contributor
|
No changes needing a change description found. |
JonathanCrd
force-pushed
the
joncarde/spector-streaming-jsonl
branch
from
952f63e to
e5cca81
Compare
JonathanCrd
changed the title
| Argument.AssertNotNull(info, nameof(info)); | ||
|
|
||
| ClientResult result = NoContentType(info.P2, info.P1, info.Action, cancellationToken.ToRequestOptions()); | ||
| ClientResult result = NoContentType(info.P2, info.P1, BinaryContent.Create(info.Action), cancellationToken.ToRequestOptions()); |
Contributor
There was a problem hiding this comment.
What you have is not incorrect since it looks like this factory method eventually serializes the model with wire options, but we also already generate an implicit operator for mrw implemented models so what was here before was more intentional. Do you think we should scope down the change to only apply this for non model types and types that are supported by the BinaryContent.Create overloads?
Member
Author
There was a problem hiding this comment.
Fair point, let me try scoping it as you suggest
JonathanCrd
force-pushed
the
joncarde/spector-streaming-jsonl
branch
from
5bab1fe to
6ed8048
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a generator bug where
MethodParameterSegmentsnavigation resolving to aBinaryDataproperty was passed directly as aBinaryContentprotocol argument without wrapping inBinaryContent.Create(), causing aCS1503compilation error.Bug Fix
When
ScmMethodProviderCollection.GetProtocolMethodArguments()navigatesMethodParameterSegmentsto resolve a property path (e.g.,stream→stream.Body), the resolvedBinaryDataexpression was passed directly as aBinaryContentprotocol argument. The fix wraps the expression withBinaryContent.Create()when the protocol parameter is a content parameter.This also fixed a pre-existing latent bug in the
Sample-TypeSpecNoContentTypemethod (info.Actionhad the same issue).Changes
ScmMethodProviderCollection.GetProtocolMethodArguments()to wrap withRequestContentApiSnippets.Create()when the protocol param is a content parameterSample-TypeSpec(side-effect of the fix)Validation
🤖 Created with JonathanCrd's copilot