Activate extension on typescript.native-preview.enable#3333
Closed
jakebailey wants to merge 1 commit intomainfrom
Closed
Activate extension on typescript.native-preview.enable#3333jakebailey wants to merge 1 commit intomainfrom
jakebailey wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the VS Code extension manifest so the extension can activate when the user runs the “Enable TypeScript Native Preview” command, preventing “command not found” errors when no TypeScript/JavaScript file is open (fixing the activation gap reported in #3312).
Changes:
- Add
onCommand:typescript.native-preview.enableto the extensionactivationEventsso thetypescript.native-preview.enablecommand can trigger activation.
mjbvz
reviewed
Apr 2, 2026
| "onLanguage:typescript", | ||
| "onLanguage:typescriptreact" | ||
| "onLanguage:typescriptreact", | ||
| "onCommand:typescript.native-preview.enable" |
Contributor
There was a problem hiding this comment.
Since you contribute the command, your extension should already be activated automatically. However there is an enablement field for that command. Could that be false for the user?
Member
Author
There was a problem hiding this comment.
No, since the enablement depends on something we explicitly set on activate
RyanCavanaugh
approved these changes
Apr 2, 2026
DanielRosenwasser
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this fixes #3312.