Preserve WinRT async error details in LocalBundleReader#16193
Draft
Copilot wants to merge 3 commits into
Draft
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comment from PR 16170
Fix: preserve winrt::hresult_error message in LocalBundleReader::LoadBundleAsync
May 28, 2026
JunielKatarn
approved these changes
May 28, 2026
Copilot
AI
changed the title
Fix: preserve winrt::hresult_error message in LocalBundleReader::LoadBundleAsync
Preserve WinRT async error details in LocalBundleReader
May 28, 2026
Copilot stopped work on behalf of
JunielKatarn due to an error
May 28, 2026 00:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a targeted review issue in
LocalBundleReader::LoadBundleAsync: WinRT async failures were being converted tostd::runtime_error, which can collapse diagnostics when surfaced throughIAsyncOperation::get().Type of Change
Erase all that don't apply.
Why
LoadBundleAsyncruns in a WinRT coroutine (IAsyncOperation<IBuffer>). Convertingwinrt::hresult_errortostd::runtime_errorin this path risks losing original WinRT error metadata/message at the async boundary.What
std::runtime_errorconversion with direct rethrow of the original WinRT exception./vnext/Microsoft.ReactNative/Utils/LocalBundleReader.cpp.Screenshots
N/A
Testing
No new tests were added for this scoped exception-handling adjustment.
Changelog
Should this change be included in the release notes: no
Preserve detailed WinRT async error information in
LocalBundleReader::LoadBundleAsyncby avoiding conversion tostd::runtime_error.