Skip to content

[2.0 servicing] WindowsAppSDK: Microsoft.Windows.Storage.ApplicationData.GetForUnpackaged()#6371

Merged
Scottj1s merged 7 commits into
release/2.0-stablefrom
user/drustheaxe/2.x-ApplicationData-Unpackaged
May 28, 2026
Merged

[2.0 servicing] WindowsAppSDK: Microsoft.Windows.Storage.ApplicationData.GetForUnpackaged()#6371
Scottj1s merged 7 commits into
release/2.0-stablefrom
user/drustheaxe/2.x-ApplicationData-Unpackaged

Conversation

@DrusTheAxe
Copy link
Copy Markdown
Member

Backport ApplicationData: Unpackaged support #6277 to 2.x

Microsoft-internal issue: https://task.ms/61684930

* ApplicationData.GetForUnpackaged() and supporting implementation

* Integrated UnpackagedApplicationData into ApplicationData

* Added tests. Removed debugging and dead code
@DrusTheAxe DrusTheAxe added this to the 2.0 milestone Apr 2, 2026
@DrusTheAxe DrusTheAxe requested a review from letao-msft April 2, 2026 02:01
@DrusTheAxe DrusTheAxe self-assigned this Apr 2, 2026
@DrusTheAxe DrusTheAxe added the area-ApplicationData Topics related to ApplicationData APIs in the Microsoft.Windows.Storage namespace label Apr 2, 2026
@DrusTheAxe
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Comment thread dev/ApplicationData/M.W.S.ApplicationData.cpp Outdated
@DrusTheAxe
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@DrusTheAxe
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@agniuks
Copy link
Copy Markdown
Contributor

agniuks commented May 27, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

#6378)

* ApplicationData: Refactor to dual-type pattern for packaged/unpackaged

Replace runtime branching (if m_unpackagedApplicationData) with separate
WinRT implementation types. Both ApplicationData and UnpackagedApplicationData
now derive directly from ApplicationDataT, and the factory constructs the
appropriate type. Same pattern applied to ApplicationDataContainer.

This eliminates 17+ repeated if-checks, removes the shared_ptr indirection
for containers, and makes each type self-contained with no branching.

* Add [[maybe_unused]] to parameters in UnpackagedApplicationData

Updated function signatures to use [[maybe_unused]] for unused parameters.

---------

Co-authored-by: agniuks <41223743+agniuks@users.noreply.github.com>
@Scottj1s
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@Scottj1s
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@Scottj1s Scottj1s merged commit 5dc2de5 into release/2.0-stable May 28, 2026
46 checks passed
@Scottj1s Scottj1s deleted the user/drustheaxe/2.x-ApplicationData-Unpackaged branch May 28, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-ApplicationData Topics related to ApplicationData APIs in the Microsoft.Windows.Storage namespace needs-triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants