fix(ios): correct RTL configuration to handle LTR case#644
Open
hggzm wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(ios): correct RTL configuration to handle LTR case#644hggzm wants to merge 1 commit intomicrosoft:mainfrom
hggzm wants to merge 1 commit intomicrosoft:mainfrom
Conversation
configRtl() had a duplicate condition bug: both branches checked ACRRtlRTL, so the LTR case (ACRRtlLTR) was never applied. Fixes microsoft#274
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-based PR (no Azure Pipelines CI). When ready for CI, push branch to upstream as
users/hggzm/clean/fix-rtl-config-274and recreate.History: upstream PRs #613 (closed)
Summary
configRtl()had a duplicate condition bug where both branches checkedACRRtlRTL. The second branch was supposed to handle theACRRtlLTRcase but was incorrectly checkingACRRtlRTLagain, soUISemanticContentAttributeForceLeftToRightwas never applied.This fix was validated on the fork's CI pipeline via
proxy/fix-rtl-config-274before creating this clean PR.Changes
ACRRtlRTLtoACRRtlLTRinconfigRtl()Before
After
Testing