Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
/plugin/skills/azure-prepare/ @microsoft/github-copilot-for-azure-writers
/plugin/skills/azure-quotas/ @rakal-dyh @RickWinter
/plugin/skills/azure-reliability/ @MadhuraBharadwaj-MSFT @saikoumudi @RickWinter
/plugin/skills/azure-resource-lookup/ @JasonYeMSFT @RickWinter
/plugin/skills/azure-resource-visualizer/ @tmeschter @RickWinter
/plugin/skills/azure-storage/ @JasonYeMSFT @RickWinter
/plugin/skills/azure-upgrade/ @MadhuraBharadwaj-MSFT @saikoumudi @RickWinter
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-all-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ jobs:
runs-on: ubuntu-latest
env:
# Skills that should be tested using vally in a JSON array
VALLY_SKILLS: '["azure-ai","azure-aigateway","azure-compliance","azure-diagnostics","azure-kusto","azure-storage","entra-app-registration","azure-messaging","airunway-aks-setup","appinsights-instrumentation","azure-cost","azure-quotas","azure-kubernetes","azure-enterprise-infra-planner","azure-resource-lookup","azure-resource-visualizer","azure-reliability","entra-agent-id","python-appservice-deploy","azure-upgrade","azure-prepare","azure-compute","azure-validate"]'
VALLY_SKILLS: '["azure-ai","azure-aigateway","azure-compliance","azure-diagnostics","azure-kusto","azure-storage","entra-app-registration","azure-messaging","airunway-aks-setup","appinsights-instrumentation","azure-cost","azure-quotas","azure-kubernetes","azure-enterprise-infra-planner","azure-resource-visualizer","azure-reliability","entra-agent-id","python-appservice-deploy","azure-upgrade","azure-prepare","azure-compute","azure-validate"]'
AZURE_CLIENT_ID: ${{ vars.AZURE_CLIENT_ID }}
AZURE_TENANT_ID: ${{ vars.AZURE_TENANT_ID }}
AZURE_SUBSCRIPTION_ID: ${{ vars.AZURE_SUBSCRIPTION_ID }}
Expand Down
289 changes: 0 additions & 289 deletions evals/azure-resource-lookup/eval.yaml

This file was deleted.

4 changes: 2 additions & 2 deletions plugin/skills/azure-prepare/references/azure-context.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,10 @@ Choices: [
- If `az quota list` returns `BadRequest` error, the resource provider doesn't support quota API

3. **For resources that don't support quota API** (e.g., Microsoft.DocumentDB, or when you get `BadRequest` from `az quota list`):
- Invoke **azure-resource-lookup** skill to count existing deployments of that resource type in the selected subscription and region
- Use Azure MCP `arm` tools to count existing deployments of that resource type in the selected subscription and region
- Use the count to calculate: `Total After Deployment = Current Count + Planned Deployment`
- Reference [Azure service limits documentation](https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/azure-subscription-service-limits) for the limit value
- Document in provisioning checklist as "Fetched from: azure-resource-lookup + Official docs"
- Document in provisioning checklist as "Fetched from: Azure MCP arm + Official docs"

4. **Validate deployment capacity**:
- Compare planned deployment quantities against available quota (limit - current usage)
Expand Down
Loading
Loading