macos build and miri check to nightly#1058
Open
harsha-simhadri wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1058 +/- ##
==========================================
- Coverage 89.51% 89.47% -0.04%
==========================================
Files 459 459
Lines 85646 85563 -83
==========================================
- Hits 76663 76555 -108
- Misses 8983 9008 +25
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
2a724bf to
ac76ef5
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated scheduled “Nightly” GitHub Actions workflow to run macOS clippy/tests and moves the Miri job out of the main CI workflow into this nightly run.
Changes:
- Added
.github/workflows/nightly.ymlscheduled workflow (macOS clippy + workspace tests, plus Ubuntu Miri). - Removed the standalone
mirijob from.github/workflows/ci.yml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/nightly.yml | New nightly workflow running macOS clippy/tests and a nightly-toolchain Miri job. |
| .github/workflows/ci.yml | Removes the previous Miri job from the main CI workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
hildebrandmw
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created nightly ci run; moved miri to nightly. added back macos build test.