Add an option setting the direction of switching workspace#348
Open
demokritos wants to merge 1 commit intomicheleg:masterfrom
demokritos:master
Open
Add an option setting the direction of switching workspace#348demokritos wants to merge 1 commit intomicheleg:masterfrom demokritos:master
demokritos wants to merge 1 commit intomicheleg:masterfrom
demokritos:master
Conversation
Owner
|
Hi, thanks for your contribution. I had a look at the code and everything seems to make sense. However, I'm a bit puzzle about the inclusion of such feature. I'm wondering if there's a way for workspace-to-dock to be more compatible without requiring change in other extensions. I'll have to think a bit about it. |
Contributor
|
@demokritos, I probably should have made the workspaces-to-dock horizontal switching an alternative instead of the default. Anyway, I can add an option that will give users a choice. |
Author
|
OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workspace-to-dock extension allows the workspaces to lay in horizontal direction. If workspaces are in horizontal direction, switching workspace by scrolling on the dock does not work. This PR adds a checkbox for horizontal workspace switching in the preference and a switcher popup source code from the Workspace-to-dock extension.